[Done] Polls on forums will not work for the next few days

jvvg · 2013-03-07 20:53:11

Currently in our poll software, there is a glitch where putting "0" as an option will make it the poll break.
I have found a fix to this problem, but it will take several days to implement. During that time, polls will be unavailable on this forum.
That means that if you post any new topics after I write this and before the solution is implemented, you will not be able to include a poll in them. This also means that existing polls will not be visible until the fix is implemented.
Due to the fact that polls can not be posted in topics, we have also disabled new topics in the polls forum until this is done, as topics in that forum must have polls and you can't post any (you can still post replies on topics, though).

Update
Polls now work again! You can put a zero as an option and they will display properly.

Last edited by jvvg (2013-03-11 18:08:59)

Molybdenum · 2013-03-07 22:07:41

Lol, why did I report this?
When you're done, could you provide us (FFers) the updated code?
I also have noticed another weird bug but am unable to replicate it (only happened once at funforums and once here): On occasion, doing something with the poll (with 0s) (not sure what - maybe voting in it?) deletes all posts after the OP.
Yay, I got linked to in the announcement

And yay, its being fixed. Though may I ask, what kind of update would take several days? Couldn't any code fix be done arabitrarily fast (limited only by typing and internet speed)?

jvvg · 2013-03-07 22:28:40

Molybdenum wrote:

Lol, why did I report this?
When you're done, could you provide us (FFers) the updated code?
I also have noticed another weird bug but am unable to replicate it (only happened once at funforums and once here): On occasion, doing something with the poll (with 0s) (not sure what - maybe voting in it?) deletes all posts after the OP.
Yay, I got linked to in the announcement
And yay, its being fixed. Though may I ask, what kind of update would take several days? Couldn't any code fix be done arabitrarily fast (limited only by typing and internet speed)?

The fix is pretty major. I'm not just moving around a few braces. I'm rewriting major portions of the mod here. Because I only know of the general area of the glitch and it would be extremely difficult to isolate it completely (the code for the poll mod was incredibly poorly written, really disorganized, and the comments are in Russian so it's pretty hard to understand), I am just going to rewrite everything related to the problematic area. This way I wipe out the glitch and improve the code.
I am also doing this on a pretty tight schedule. I will not be able to code for any of tomorrow and only for about an hour or two on Saturday.

Molybdenum · 2013-03-07 22:51:59

jvvg wrote:

Molybdenum wrote:
Lol, why did I report this?
When you're done, could you provide us (FFers) the updated code?
I also have noticed another weird bug but am unable to replicate it (only happened once at funforums and once here): On occasion, doing something with the poll (with 0s) (not sure what - maybe voting in it?) deletes all posts after the OP.
Yay, I got linked to in the announcement
And yay, its being fixed. Though may I ask, what kind of update would take several days? Couldn't any code fix be done arabitrarily fast (limited only by typing and internet speed)?
The fix is pretty major. I'm not just moving around a few braces. I'm rewriting major portions of the mod here. Because I only know of the general area of the glitch and it would be extremely difficult to isolate it completely (the code for the poll mod was incredibly poorly written, really disorganized, and the comments are in Russian so it's pretty hard to understand), I am just going to rewrite everything related to the problematic area. This way I wipe out the glitch and improve the code.
I am also doing this on a pretty tight schedule. I will not be able to code for any of tomorrow and only for about an hour or two on Saturday.

Braces? C? What? (I use python a lot ( ) even though I should be using VB)
But since its so major, you haven't exactly

jvvg wrote:

found a fix to this problem

(I though you knew exactly what to change)
And lol at comments in russian Was the creator russian or something?

jvvg · 2013-03-07 22:56:35

Molybdenum wrote:

jvvg wrote:
Molybdenum wrote:
Lol, why did I report this?
When you're done, could you provide us (FFers) the updated code?
I also have noticed another weird bug but am unable to replicate it (only happened once at funforums and once here): On occasion, doing something with the poll (with 0s) (not sure what - maybe voting in it?) deletes all posts after the OP.
Yay, I got linked to in the announcement
And yay, its being fixed. Though may I ask, what kind of update would take several days? Couldn't any code fix be done arabitrarily fast (limited only by typing and internet speed)?
The fix is pretty major. I'm not just moving around a few braces. I'm rewriting major portions of the mod here. Because I only know of the general area of the glitch and it would be extremely difficult to isolate it completely (the code for the poll mod was incredibly poorly written, really disorganized, and the comments are in Russian so it's pretty hard to understand), I am just going to rewrite everything related to the problematic area. This way I wipe out the glitch and improve the code.
I am also doing this on a pretty tight schedule. I will not be able to code for any of tomorrow and only for about an hour or two on Saturday.
Braces? C? What? (I use python a lot ( ) even though I should be using VB)
But since its so major, you haven't exactly
jvvg wrote:
found a fix to this problem
(I though you knew exactly what to change)
And lol at comments in russian Was the creator russian or something?

@Braces: Well, this website is programmed in PHP, which is a language with the same syntax as C, but it is a different language designed specifically for web programming.
@Haven't found a fix: I know where the problem is and what I have to rewrite. I also have a general idea of how I can fix the [bad] old code with my [awesome] new code.
@Russian: Yes, he is Russian.

Devloper123 · 2013-03-08 13:40:14

OK

Molybdenum · 2013-03-08 17:42:33

jvvg wrote:

@Braces: Well, this website is programmed in PHP, which is a language with the same syntax as C, but it is a different language designed specifically for web programming.
@Haven't found a fix: I know where the problem is and what I have to rewrite. I also have a general idea of how I can fix the [bad] old code with my [awesome] new code.
@Russian: Yes, he is Russian.

Lol, ok.

jvvg · 2013-03-10 13:32:49

UPDATE:
Old polls are now visible again as read-only. This means you can't vote in them right now.

jvvg · 2013-03-10 13:49:01

You can now vote in old polls. However, posting or editing polls will not come for a little while.

Molybdenum · 2013-03-10 21:31:50

Yeah, it still looks weird, like last editted is in the poll box, and results are displayed at the same time as voting

jvvg · 2013-03-11 18:09:18

Polls are now completely fixed. If any more problems arise, please report them.

SFollis · 2013-03-12 11:03:13

jvvg wrote:

Polls are now completely fixed. If any more problems arise, please report them.

awesome!

Molybdenum · 2013-03-12 18:30:34

I tried it, it seems fixed so far. Could you put the code somewhere for us?

jvvg · 2013-03-12 21:35:03

Molybdenum wrote:

I tried it, it seems fixed so far. Could you put the code somewhere for us?

It turned out the problem was just a data type issue, so I ended up keeping the old code and fixing it. Just use a bit of PHP knowledge and apply it to the standard poll mod!
I will also include this fix the next time I push the source code (which I should do sometime soon, as I haven't done so in several months).

Mod Share

Mod Share Forums

#1 2013-03-07 20:53:11

[Done] Polls on forums will not work for the next few days

#2 2013-03-07 22:07:41

Re: [Done] Polls on forums will not work for the next few days

#3 2013-03-07 22:28:40

Re: [Done] Polls on forums will not work for the next few days

#4 2013-03-07 22:51:59

Re: [Done] Polls on forums will not work for the next few days

#5 2013-03-07 22:56:35

Re: [Done] Polls on forums will not work for the next few days

#6 2013-03-08 13:40:14

Re: [Done] Polls on forums will not work for the next few days

#7 2013-03-08 17:42:33

Re: [Done] Polls on forums will not work for the next few days

#8 2013-03-10 13:32:49

Re: [Done] Polls on forums will not work for the next few days

#9 2013-03-10 13:49:01

Re: [Done] Polls on forums will not work for the next few days

#10 2013-03-10 21:31:50

Re: [Done] Polls on forums will not work for the next few days

#11 2013-03-11 18:09:18

Re: [Done] Polls on forums will not work for the next few days

#12 2013-03-12 11:03:13

Re: [Done] Polls on forums will not work for the next few days

#13 2013-03-12 18:30:34

Re: [Done] Polls on forums will not work for the next few days

#14 2013-03-12 21:35:03

Re: [Done] Polls on forums will not work for the next few days

Board footer